A little while ago, our MIS provider did some work for us to resolve some performance issues with their product. When I got the code back, I took a look over it as I needed to make some further small adjustments myself to make it completely fit our needs.
Since then, I have found myself unravelling almost every aspect of the code. I’ve found data queries that use a SELECT DISTINCT on 500 records to return 8 values that exist as unique items in a different table of 30 records. WHERE clauses with 2 different parameters that can only ever return data if they are identical. Even code that I looked at a week ago and thought “huh, that’s an odd way to do it, but it seems to work” is slowly proving itself to be mindnumbingly dumb the more I dig into the inner workings.
It doesn’t disturb me that I’m finding these errors. It’s a complex system. What disturbs me is that I’ve had no formal training on this system, and the person who did the work is the MIS company’s expert on it.
There are times – increasingly frequent times – when I seriously wonder how they have survived in the market this long.